[PATCH] D37686: [DAG] Consolidating Instruction->SDNode Flags propagation in one class for better code management.

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 08:12:35 PDT 2017


hfinkel added inline comments.


================
Comment at: include/llvm/CodeGen/SelectionDAGNodes.h:357
   bool AnyDefined : 1;
+  // When true Flags from DAG node are propagated to its operands
+  // for which AcquireFlagsFromUser is true.
----------------
Add a comma after true.


================
Comment at: include/llvm/CodeGen/SelectionDAGNodes.h:361
+  // When true then DAG node is a candidate for inheriting Flags
+  // from its user.
+  bool AcquireFlagsFromUser : 1;
----------------
Please explain here when these flags are set/unset and why.


https://reviews.llvm.org/D37686





More information about the llvm-commits mailing list