[PATCH] D37734: [GlobalISel][X86] G_FCONSTANT support.

[Elena Demikhovsky via Phabricator via llvm-commits]

delena added inline comments.


================
Comment at: lib/Target/X86/X86InstructionSelector.cpp:1220
+  // Create the load from the constant pool.
+  const ConstantFP *CFP = I.getOperand(1).getFPImm();
+  unsigned CPI = MF.getConstantPool()->getConstantPoolIndex(CFP, Align);
----------------
Can PCIBase remain 0? According to the code, you calculate PCIBase for the Large  model, but do not use it.


================
Comment at: lib/Target/X86/X86InstructionSelector.cpp:1222
+  unsigned CPI = MF.getConstantPool()->getConstantPoolIndex(CFP, Align);
+  MachineInstr *LoadInst = NULL;
+
----------------
nullptr


https://reviews.llvm.org/D37734