[PATCH] D37733: [ELF} - Implement --push-state/--pop-state.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 01:21:04 PDT 2017


grimar added a comment.

In https://reviews.llvm.org/D37733#868245, @ruiu wrote:

> I think I don't really like this option. This seems too hairy feature to me. I believe it shouldn't have been added to the linker in the first place.


Its wierd feature indeed. It was reported (https://stackoverflow.com/questions/37603238/fsanitize-not-using-gold-linker-in-gcc-6-1) that `-fuse-ld=gold`
could be a workaround previously for use of gcc -fsanitize. But now gold also supports it and I wonder what would be the correct behavior for LLD.
If we don't support it them most likely will fail, though feature itself and its description looks not worked out well for me.
I think we can put this on hold for now and watch.


https://reviews.llvm.org/D37733





More information about the llvm-commits mailing list