[PATCH] D37776: Add options to dump PGO counts in text.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 12 15:53:52 PDT 2017


davidxl added inline comments.


================
Comment at: lib/Transforms/Instrumentation/PGOInstrumentation.cpp:181
+// Command line option to turn on CFG dot dump of raw profile counts
+static cl::opt<bool>
+    PGOPrintRawCounts("pgo-print-raw-counts", cl::init(false), cl::Hidden,
----------------
To share most of the code, I think it is better to make PGOViewRawCounts an enum type option, just like:

ViewBlockFreqPropagationDAG

By doing so, we can do:

-pgo-view-raw-counts=graph --> dump dot graph
-pgo-view-raw-counts=text --> dump text

similarly for the other option.


https://reviews.llvm.org/D37776





More information about the llvm-commits mailing list