[PATCH] D36579: [ELF] - Do not fail when set versions for linkerscript's symbol aliases

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 12 00:46:17 PDT 2017


grimar added inline comments.


================
Comment at: ELF/Driver.cpp:1028
+      if (Cmd->Name != "." && !Symtab->find(Cmd->Name) && !Cmd->Provide)
+        Symtab->addAbsolute<ELFT>(Cmd->Name, STV_DEFAULT, STB_WEAK);
+
----------------
ruiu wrote:
> grimar wrote:
> > ruiu wrote:
> > > Is there any reason to create symbols as STB_WEAK?
> > Yes, please refer to my comment above:
> > https://reviews.llvm.org/D36579#861990
> I don't think adding symbols as weak symbols is a right thing to do, if the problem is just for _gp. It implies that _gp's handling is not right.
I changed how `_gp` and other special symbols affected are created, added testcase.


https://reviews.llvm.org/D36579





More information about the llvm-commits mailing list