[PATCH] D37718: [ELF] Handle references to garbage collected common symbols

ben via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 11 18:17:34 PDT 2017


bd1976llvm added a comment.

In https://reviews.llvm.org/D37718#867246, @ruiu wrote:

> I don't remember why we don't have this check in getSymVA() for DefinedRegularKind. Should we actually be returning 0 for DefinedRegular if sections are dead too?


Definitely.  I also think that we should change the code to treat regular and common symbols in the same way when it is possible.


https://reviews.llvm.org/D37718





More information about the llvm-commits mailing list