[PATCH] D37019: Add select simplifications

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:721
   // (op (select (a, c, b)), (select (a, d, b))) -> (select (a, (op c, d), 0))
   // (op (select (a, b, c)), (select (a, b, d))) -> (select (a, 0, (op c, d)))
+  Value *A1, *B1, *C1, *A2, *B2, *C2;
----------------
qcolombet wrote:
> The comment seems weird to me.
> Shouldn't it be:
> (op (select (a, c, b)), (select (a, d, b))) -> (select (a, (op c, d), (op d, b)))?
> 
> Also I don't get why there is two of them :).
I screwed up the variable naming but you get it! (op something something instead of 0)


https://reviews.llvm.org/D37019