[PATCH] D36835: [llvm-dwarfdump] Hide .debug_str and die reference offsets in brief mode

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 11 13:00:11 PDT 2017


On Mon, Sep 11, 2017 at 12:38 PM Jonas Devlieghere via Phabricator <
reviews at reviews.llvm.org> wrote:

> JDevlieghere added a comment.
>
> Hi Dave,
>
> The positive tests have been committed as part of
> https://reviews.llvm.org/D37334 because I had to change the test anyway.
> Let me know if you think something is still missing!
>

Looks good - for future work, would it be worth removing the () around the
attribute value as well, in brief mode?


>
> With regards to dropping the prefixes, I talked to Adrian and he makes a
> pretty good argument in favor of keeping them. Maybe this is something to
> discuss on the mailing list as an NFC? I've had a look and implementing
> this should be relatively straightforward so it really boils down to
> whether we want to do this or not.
>

Yeah, I think it'd be good to have a discussion around that.

Thanks!
- Dave


>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D36835
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170911/70d68156/attachment.html>


More information about the llvm-commits mailing list