[PATCH] D36558: [llvm-objcopy] Add support for nested and overlapping segments

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich updated this revision to Diff 114626.
jakehehrlich added a comment.

1. Fixed typos and test names
2. Made recommended change to skipping certain segments. I used MemSize to check that the size is zero because FileSize could be zero while MemSize would not be. If a segment covers only SHT_NOBITS read only sections then it's offset is technically free to be whatever I believe and it would have to have FileSize be zero. In practice it will be something more sensible but it seemed right t cover this case.


Repository:
  rL LLVM

https://reviews.llvm.org/D36558

Files:
  test/tools/llvm-objcopy/adjacent-segments.test
  test/tools/llvm-objcopy/identical-segments.test
  test/tools/llvm-objcopy/overlap-chain.test
  test/tools/llvm-objcopy/pt-phdr.test
  test/tools/llvm-objcopy/tripple-overlap.test
  tools/llvm-objcopy/Object.cpp
  tools/llvm-objcopy/Object.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36558.114626.patch
Type: text/x-patch
Size: 19308 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170911/af23d9ec/attachment.bin>