[PATCH] D37389: [AMDGPU] Produce madak and madmk from the two-address pass

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 11 09:19:05 PDT 2017


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with the minor cleanup



================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:2139
+      return BuildMI(*MBB, MI, MI.getDebugLoc(),
+                     get(IsF16 ? AMDGPU::V_MADAK_F16 : AMDGPU::V_MADAK_F32))
+               .add(*Dst)
----------------
Assign the opcode to a variable instead of repeating this 3 places


https://reviews.llvm.org/D37389





More information about the llvm-commits mailing list