[PATCH] D37625: [DWARF] Incorrect prologue end line record.

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 11 07:22:32 PDT 2017


CarlosAlbertoEnciso added a comment.

In https://reviews.llvm.org/D37625#865095, @probinson wrote:

> I'm actually more curious why part of the prologue is associated with line 5 and part with line 7.  That feels like there's some pass mis-handling debug locations, and it would be preferable to find that rather than have DwarfDebug cover it up.


I understand your valid point, but I think the check introduced by this proposed patch will guarantee that no line records are associated to instructions that are part of the frame setup code.

May I suggest, to keep the extra check and investigate why part of the prologue is associated with line 5 and part with line 7 as a second part of the problem, unless you feel otherwise.


https://reviews.llvm.org/D37625





More information about the llvm-commits mailing list