[PATCH] D29641: [SLP] Fix for PR31847: Assertion failed: (isLoopInvariant(Operands[i], L) && "SCEVAddRecExpr operand is not loop-invariant!")

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

What state is this in? PR31847 was cleared as a 5.0.0 blocker, so it probably won't need to be merged for 5.0.1 either



================
Comment at: test/Transforms/SLPVectorizer/X86/crash-SCEV.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -slp-vectorizer -S -o - -mtriple=i386 -mcpu=haswell < %s | FileCheck %s
----------------
ABataev wrote:
> Gerolf wrote:
> > What is this supposed to test? I'm wondering if there can be a smaller test for what this one is supposed to do. As is at the least it looks hard to maintain.
> This is a reproducer, that currently crashes the compiler for sure. I tried to make it as small as possible, but could not reduce it anymore.
Possibly rename the test file pr31847.ll? Test called 'crash' etc. aren't that useful imo.


https://reviews.llvm.org/D29641