[PATCH] D37507: Fix maximum legal VF calculation

[Dorit Nuzman via Phabricator via llvm-commits]

dorit added a comment.

Looks fine to me (with a couple very minor dbg reports improvements).
@Ayal/@hfinkel - what do you say?



================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:6281
       // a member at index zero.
       if (Group->isReverse()) {
         releaseGroup(Group);
----------------
Not strictly related to your patch, but since you are already adding a missing "Invalidate candidate interleave group" message above for the case that shows up in PR34283 (thanks!) , might as well also add a similar message that's missing here (where we invalidate a candidate interleave group due to a reverse access with gaps).


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:6378
                << WidestType << " bits.\n");
   DEBUG(dbgs() << "LV: The Widest register is: " << WidestRegister
                << " bits.\n");
----------------
Another small nit not related to your patch, but while we're here: would be nice to make this message a bit clearer, e.g. "... Widest register safe to use is..."


https://reviews.llvm.org/D37507