[PATCH] D33601: libunwind: fix building on mingw-w64

Mateusz MikuĊ‚a via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 9 02:24:40 PDT 2017


mati865 added inline comments.


================
Comment at: src/AddressSpace.hpp:293
         return false;
-#if __LP64__
+#if defined(__LP64__) || defined(_WIN64)
       const struct mach_header_64 *mh = (const struct mach_header_64 *)dlinfo.dli_fbase;
----------------
compnerd wrote:
> Huh?  This doesn't make sense.  `mach_header_64` on `_WIN64`?  Plus, how does `dladdr` work here?
It's guarded by `__APPLE__` and probably was added by mistake when modifying `__LP64__` checks.


Repository:
  rL LLVM

https://reviews.llvm.org/D33601





More information about the llvm-commits mailing list