[PATCH] D37654: PPC: Don't select lxv/stxv for insufficiently aligned stack slots.

Nemanja Ivanovic via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 9 01:46:32 PDT 2017


Ah, OK good. So I imagine it failed the machine verifier.
That's good - as long as we don't emit bad code :)

On Sat, Sep 9, 2017 at 9:54 AM, Eric Christopher <echristo at gmail.com> wrote:

> It failed in the register scavenger :)
>
> On Fri, Sep 8, 2017, 11:46 PM Nemanja Ivanovic via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> nemanjai added a comment.
>>
>> I imagine this patch was prompted by a bug. Just out of curiosity, did
>> the assert:
>>
>>   assert(MO.isImm() && !(MO.getImm() % 16) &&
>>          "Expecting an immediate that is a multiple of 16");
>>
>> fire for the case where the frame op was lowered to an lxv/stxv with an
>> offset that isn't a multiple of 16? If not, perhaps we need another assert
>> somewhere else?
>>
>>
>> Repository:
>>   rL LLVM
>>
>> https://reviews.llvm.org/D37654
>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170909/636fd172/attachment.html>


More information about the llvm-commits mailing list