[PATCH] D37581: Implement pagerando wrapper functions to initialize POT register

[Vlad Tsyrklevich via Phabricator via llvm-commits]

vlad.tsyrklevich added a comment.

small style nit: omit curly brackets for single-statement if/for/etc. statements.



================
Comment at: lib/Transforms/IPO/PagerandoWrappers.cpp:77
+      || F.hasComdat()  // TODO: Support COMDAT
+      || isa<UnreachableInst>(F.getEntryBlock().getTerminator());
+      // Above condition is different from F.doesNotReturn(), which we do not
----------------
Could you explain this condition?


================
Comment at: lib/Transforms/IPO/PagerandoWrappers.cpp:129
+
+  F->setSection("");
+  F->addFnAttr(Attribute::PagerandoBinned);
----------------
What's the purpose of setting the Function section to the default here?


================
Comment at: lib/Transforms/IPO/PagerandoWrappers.cpp:295
+    DestArg->takeName(&A);
+    DestArg++;
+  }
----------------
nit: https://llvm.org/docs/CodingStandards.html#prefer-preincrement


https://reviews.llvm.org/D37581