[PATCH] D37644: [CMake][runtimes] Use list of lists rather than ":" delimiters

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: runtimes/CMakeLists.txt:349
     foreach(runtime_name ${runtime_names})
-      list(APPEND ${name}_extra_targets
-        "${runtime_name}:${runtime_name}-${name}"
-        "install-${runtime_name}:install-${runtime_name}-${name}")
+      set(${name}_${runtime_name} ${runtime_name} ${runtime_name}-${name})
+      set(${name}_install_${runtime_name} install-${runtime_name} install-${runtime_name}-${name})
----------------
I'm wandering whether we even need list of lists here, we may as well just do `set(${runtime_name}-${name} ${runtime_name})` and in `llvm_ExternalProject_Add` just check if the variable is defined, if so use its value otherwise use it as string. What do you think about that approach?


Repository:
  rL LLVM

https://reviews.llvm.org/D37644