[PATCH] D37637: [CMake] Determine early on which projects are enabled

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 8 14:55:24 PDT 2017


zturner updated this revision to Diff 114436.
zturner added a comment.

Updated to look for all projects in the `runtimes` and `projects` folder.

Also worth mentioning is that `projects/CMakeLists.txt` seems to have some hackish code that appears to be a workaround for the fact the feature I'm adding in this patch doesn't exist.  Specifically, it first adds a bunch of known projects that don't depend on each other in a random order.  Then it adds a couple of specific projects that do depend on each other in the right order so that they can use `if (TARGET foo)` to check for existence.

After this patch, the entire set of valid projects that are present in the tree can probably be added in any order, as long as each `CMakeLists.txt` is updated to use the proper `LLVM_PROJECT_foo_ENABLED` variable, rather than an `if (TARGET foo)` check.


https://reviews.llvm.org/D37637

Files:
  compiler-rt/CMakeLists.txt
  llvm/CMakeLists.txt
  llvm/cmake/modules/AddLLVM.cmake

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37637.114436.patch
Type: text/x-patch
Size: 5412 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170908/3ff5d507/attachment.bin>


More information about the llvm-commits mailing list