[PATCH] D37536: [compiler-rt] Move IsStackOverflow from asan into sanitizer_common

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl added inline comments.


================
Comment at: compiler-rt/lib/tsan/go/buildgo.sh:48
 		../rtl/tsan_platform_linux.cc
+		../../sanitizer_common/sanitizer_platform_limits_posix.cc
 		../../sanitizer_common/sanitizer_posix.cc
----------------
vitalybuka wrote:
> alekseyshl wrote:
> > What prompted it?
> IsStackOverflow needs some constants from the file.
> I don't like #ifs in the code, but maybe safer just to keep them instead of new file here.
> What would be your preference here?
Well, if we need IsStackOverflow in Go mode, we have to add this file, if we do not need IsStackOverflow (and, maybe, some other functions from sanitizer_posix.cc), we should split it out into a separate file and do not link it here.


https://reviews.llvm.org/D37536