[PATCH] D37627: [LLD][ELF] Rename variables and add comments to getISThunkSec [NFC]

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 8 09:48:13 PDT 2017


smeenai accepted this revision.
smeenai added inline comments.
This revision is now accepted and ready to land.


================
Comment at: ELF/Relocations.cpp:1028
+// precedes its Target.
 ThunkSection *ThunkCreator::getISThunkSec(InputSection *IS, OutputSection *OS) {
   ThunkSection *TS = ThunkedSections.lookup(IS);
----------------
As far as I can see `OS` isn't used in this function anywhere. Can that parameter be dropped entirely? (I'm fine with that being done in a follow-up if it's possible.)


https://reviews.llvm.org/D37627





More information about the llvm-commits mailing list