[PATCH] D37528: [JumpThreading] Preserve dominance across the pass.

Sebastian Pop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 8 06:54:47 PDT 2017


sebpop added a comment.

In https://reviews.llvm.org/D37528#864259, @dberlin wrote:

> In https://reviews.llvm.org/D37528#864194, @brzycki wrote:
>
> > In https://reviews.llvm.org/D37528#863731, @kuhar wrote:
> >
> > > @brzycki, one related thing: have you tried preserving postdominators as well? I'm not sure if that would be beneficial here, but in theory, it should be pretty simple, as you can pass exactly the same update sequences to the DominatorTree and PostDominatorTree.
> >
> >
> > I have not. I'll talk to @sebpop and see if he thinks this makes sense to include in this patch. Depending on our follow-on updates to JT we may need post dominators as well.
>
>
> Even if you don't need it, it's trivial to preserve and probably worth doing.


Agreed.  Preserving post-dominators will also save some compilation time which is always good to get.


https://reviews.llvm.org/D37528





More information about the llvm-commits mailing list