[PATCH] D37567: [llvm-readobj] - Teach tool to report error if some section is in multiple COMDAT groups at once.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 8 04:24:10 PDT 2017


>> Can we have a common code path for printing the error in both cases?
>
>I think no, because GNU style and LLVM styles are (or can be at least) different.
>As far I understand we must follow the GNU style when -elf-output-style=GNU,
>but I would use more suitable/convinent one for LLVM style (like in this patch, for example).

It should be possible to refactor printGroupSections to split object parsing from
printing results though. I guess that is what you meant probably.
I'll try to do that change and post the patch.

George.


More information about the llvm-commits mailing list