[PATCH] D37389: [AMDGPU] Produce madak and madmk from the two-address pass

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 15:26:24 PDT 2017


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:2134
+    if (auto Imm = getFoldableImm(Src2))
+      return BuildMI(*MBB, MI, MI.getDebugLoc(), get(AMDGPU::V_MADAK_F32))
+               .add(*Dst)
----------------
rampitec wrote:
> arsenm wrote:
> > What if this is an f16 mac?
> "if (!IsF16 ..." on line 2132.
But we can handle f16 here as well, so might as well


https://reviews.llvm.org/D37389





More information about the llvm-commits mailing list