[PATCH] D37570: [XRay][CodeGen][PowerPC] Fix tail exit codegen for XRay in PPC

Tim Shen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 18:10:04 PDT 2017


timshen added inline comments.


================
Comment at: lib/CodeGen/XRayInstrumentation.cpp:118
-      }
-      if (TII->isTailCall(T)) {
-        Opc = TargetOpcode::PATCHABLE_TAIL_CALL;
----------------
dberris wrote:
> timshen wrote:
> > This is actively removing PATCHABLE_TAIL_CALL emits, and it affects all architectures.
> > 
> > Can we add x86 tests for tracking the decisions we've made?
> Note that this function only gets called for non-X86 architectures (where prepending is the correct solution).
> 
> We already have tests in X86 for the tail call exit sled lowering. Those pass with this change.
We have other non-x86 targets like aarch64, right? How do those targets test this?


https://reviews.llvm.org/D37570





More information about the llvm-commits mailing list