[PATCH] D37602: Properly hook debuginfo-tests up to lit and CMake

[Jonathan Roelofs via Phabricator via llvm-commits]

jroelofs added a comment.

Unless you're going for "make this lit.cfg as close as possible to clang's", then...



================
Comment at: debuginfo-tests/lit.cfg:141
+
+config.substitutions.append( ('%llvmshlibdir', config.llvm_shlib_dir) )
+config.substitutions.append( ('%pluginext', config.llvm_plugin_ext) )
----------------
Probably don't need `%llvmshlibdir`.


================
Comment at: debuginfo-tests/lit.cfg:142
+config.substitutions.append( ('%llvmshlibdir', config.llvm_shlib_dir) )
+config.substitutions.append( ('%pluginext', config.llvm_plugin_ext) )
+config.substitutions.append( ('%PATH%', config.environment['PATH']) )
----------------
Probably don't need `%pluginext`.


================
Comment at: debuginfo-tests/lit.cfg:188
+
+config.substitutions.append( ('%clang_analyze_cc1', '%clang_cc1 -analyze %analyze') )
+config.substitutions.append( ('%clang_cc1',
----------------
Probably don't need `clang_analyze_cc1`.


================
Comment at: debuginfo-tests/lit.cfg:282
+# clang to run with -rtlib=libgcc.
+if platform.system() not in ['Darwin', 'Fuchsia', 'Windows']:
+    config.available_features.add('libgcc')
----------------
Probably don't need libgcc as an available feature.


================
Comment at: debuginfo-tests/lit.cfg:292
+# Tests that require the /dev/fd filesystem.
+if os.path.exists("/dev/fd/0") and sys.platform not in ['cygwin']:
+    config.available_features.add('dev-fd-fs')
----------------
Probably don't need def-fd-fs as an available feature.


https://reviews.llvm.org/D37602