[PATCH] D37602: Properly hook debuginfo-tests up to lit and CMake

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 16:54:48 PDT 2017


zturner added inline comments.


================
Comment at: debuginfo-tests/lit.cfg:330
+    return set_of_features
+
+config.available_features.update(get_llvm_config_props())
----------------
rnk wrote:
> This duplication sucks. We should install it in llvm's share directory next to its cmake or something, so that we can import it.
Indeed it does.  But at the same time, debug info tests don't need half of the stuff clang's is doing.  Is there a good way to extract out the useful bits into something that is more general than just "these two specific projects need to share some specific functions"?  Is there a way to make it useful for all projects?


https://reviews.llvm.org/D37602





More information about the llvm-commits mailing list