[PATCH] D37595: AMDGPU: Recompute scc liveness

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In https://reviews.llvm.org/D37595#864031, @arsenm wrote:

> In https://reviews.llvm.org/D37595#864026, @rampitec wrote:
>
> > It shall be caught by the operands analysis below and added only if needed. Do you have test showing problem?
>
>
> Yes, it's pretty big though. It seems to only remove one s_or_b64 in it though.


I think it should not be added here. Instead it shall be added where S_OR_B64 is removed. Then maybe the loop from the first part also has to be copied into the second part of the function, where this instruction is removed:

  for (auto &Op : I->operands())
    if (Op.isReg())
      RecalcRegs.insert(Op.getReg());


https://reviews.llvm.org/D37595