[PATCH] D37489: Linker script handing of file patterns with COMMON defs

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 15:19:33 PDT 2017


ruiu added a comment.

Our philosophy of re-implementing a linker is to not copy features without verifying that doing that makes sense. So I think we shouldn't have sorted common symbols in the first place. We can bring it back when it is proved to be useful, but until then, I think I prefer removing the code to sort common symbols.


https://reviews.llvm.org/D37489





More information about the llvm-commits mailing list