[PATCH] D37364: [DWARF] Line 0 should not have a discriminator

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 15:04:55 PDT 2017


probinson added a comment.

In https://reviews.llvm.org/D37364#863979, @dblaikie wrote:

> Seems OK to me
>
> For a minor perk - would it be possible to test the line table length? Since the benefit (smaller line table) of this change isn't readily apparent in the high level line table printing that dwarfdump does. I know it'd make the test a bit more brittle.


Yeah... I can add checks for both total_length and prologue_length, with a comment that says what we really care about is that the difference doesn't change unexpectedly.  The metadata is specifying DWARF 4 so it shouldn't be *that* brittle.


https://reviews.llvm.org/D37364





More information about the llvm-commits mailing list