[llvm] r312739 - [XRay][tools] Disable windows for tests that use an unsupported shell redirect.

[Reid Kleckner via llvm-commits]

This didn't actually fix the Windows bots. The test should be fixed in
r312747. You can use the 'not' utility to test for non-zero exit codes
instead of subshells.

On Thu, Sep 7, 2017 at 12:10 PM, Keith Wyss via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: kpw
> Date: Thu Sep  7 12:10:34 2017
> New Revision: 312739
>
> URL: http://llvm.org/viewvc/llvm-project?rev=312739&view=rev
> Log:
> [XRay][tools] Disable windows for tests that use an unsupported shell
> redirect.
>
> The tests are filechecking against stderr and use some magic to make
> stdout go
> away and pipe stderr to FileCheck. This broke bots on windows.
>
> Modified:
>     llvm/trunk/test/tools/llvm-xray/X86/stack-empty-case.yaml
>     llvm/trunk/test/tools/llvm-xray/X86/stack-keep-going.yaml
>
> Modified: llvm/trunk/test/tools/llvm-xray/X86/stack-empty-case.yaml
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/
> llvm-xray/X86/stack-empty-case.yaml?rev=312739&r1=
> 312738&r2=312739&view=diff
> ============================================================
> ==================
> --- llvm/trunk/test/tools/llvm-xray/X86/stack-empty-case.yaml (original)
> +++ llvm/trunk/test/tools/llvm-xray/X86/stack-empty-case.yaml Thu Sep  7
> 12:10:34 2017
> @@ -1,3 +1,8 @@
> +# The redirects used in the commands to FileCheck against stderr cannot
> be used
> +# with a windows test.
> +#
> +# UNSUPPORTED: windows
> +
>  #RUN: (llvm-xray stack %s 2>&1 || echo "Checking Command Failed") |
> FileCheck %s
>  ---
>  header:
>
> Modified: llvm/trunk/test/tools/llvm-xray/X86/stack-keep-going.yaml
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/
> llvm-xray/X86/stack-keep-going.yaml?rev=312739&r1=
> 312738&r2=312739&view=diff
> ============================================================
> ==================
> --- llvm/trunk/test/tools/llvm-xray/X86/stack-keep-going.yaml (original)
> +++ llvm/trunk/test/tools/llvm-xray/X86/stack-keep-going.yaml Thu Sep  7
> 12:10:34 2017
> @@ -1,3 +1,8 @@
> +# The redirects used in the commands to FileCheck against stderr cannot
> be used
> +# with a windows test.
> +#
> +# UNSUPPORTED: windows
> +
>  #RUN: (llvm-xray stack %s 2>&1 1>&- || echo "Check Command Failed") |
> FileCheck --check-prefix HALT %s
>  #RUN: (llvm-xray stack -k %s 2>&1 && echo "Check Command Succeeded") |
> FileCheck --check-prefix KEEP-GOING-SUCCEEDS %s
>  #RUN: llvm-xray stack -k %s | FileCheck --check-prefix KEEP-GOING %s
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170907/965c456a/attachment.html>