[PATCH] D37451: [x86] enable storeOfVectorConstantIsCheap() target hook

[Zvi Rackover via Phabricator via llvm-commits]

zvi added a comment.

Intuitively, it seems to me that choosing a minimum threshold, as suggested in note 2, is a better option.
Another concern for store-merging in general: are we more susceptible to losing store-to-load forwarding? I know that Intel pre-Nehalem processors had some limitations that were later improved. Sorry i can't recall the full details from the top of my head. Will look later at the Optimization Manual for the info.


https://reviews.llvm.org/D37451