[PATCH] D37541: llvm-lib: add a feature to merge library files.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/lib/ToolDrivers/llvm-lib/LibDriver.cpp:181
+
+    Members.push_back(NewArchiveMember(MBOrErr.get()));
+    Members.back().IsNew = true;
----------------
Is this correct for thin archives? I believe that memory buffers for members of thin archives are owned by the `Archive` object.

Speaking of thin archives, we probably need to prevent this feature from being used with `/llvmlibthin` unless all input archives are thin.


https://reviews.llvm.org/D37541