[PATCH] D37397: AMDGPU: Handle more than one memory operand in SIMemoryLegalizer

Tony Tye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 6 16:41:25 PDT 2017


t-tye accepted this revision.
t-tye added a comment.

LGTM with one suggested name change.



================
Comment at: lib/Target/AMDGPU/SIMemoryLegalizer.cpp:190
 /* static */
+Optional<SIMemOpInfo> SIMemOpInfo::constructFromMI(
+    const MachineBasicBlock::iterator &MI) {
----------------
Suggest renaming to constructFromMIWithMMO since it only can be used when the instruction has MMOs.


https://reviews.llvm.org/D37397





More information about the llvm-commits mailing list