[PATCH] D36619: [MachineCombiner] Update instruction depths incrementally for large BBs.

Gerolf Hoflehner via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 6 16:08:10 PDT 2017


SGTM.

> On Sep 6, 2017, at 10:21 AM, Florian Hahn via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> fhahn added a comment.
> 
> Thank you very much for having a look! I'll address your comments tomorrow and go ahead committing the patch. Also, this patch depends on https://reviews.llvm.org/D36696, which is a NFC that moves the code to update the instruction depths to a separate function (in MachineTraceMetrics.cpp). Pending further objections, I'll commit this patch as well tomorrow.
> 
> 
> https://reviews.llvm.org/D36619
> 
> 
> 



More information about the llvm-commits mailing list