[PATCH] D37522: [AMDGPU] Fixed encoding of v_pk_mul_f16 in fcanonicalize

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 6 11:08:22 PDT 2017


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with constant adjusted



================
Comment at: lib/Target/AMDGPU/SIInstructions.td:1325
   (fcanonicalize (v2f16 (VOP3PMods v2f16:$src, i32:$src_mods))),
-  (V_PK_MUL_F16 SRCMODS.OP_SEL_1, (i32 CONST.V2FP16_ONE), $src_mods, $src, DSTCLAMP.NONE)
+  (V_PK_MUL_F16 0, (i32 CONST.V2FP16_ONE), $src_mods, $src, DSTCLAMP.NONE)
 >;
----------------
Since there isn't really a V2FP16_ONE inline immediate, this should be changed to just FP16_ONE


https://reviews.llvm.org/D37522





More information about the llvm-commits mailing list