[PATCH] D36862: AMDGPU: Handle non-temporal loads and stores

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added inline comments.


================
Comment at: lib/Target/AMDGPU/SIMemoryLegalizer.cpp:235
   AtomicOrdering FailureOrdering = AtomicOrdering::NotAtomic;
+  bool IsNonTemporal = true;
 
----------------
t-tye wrote:
> If there are are no MMOs then the default ought to be false.
Discussed offline.


================
Comment at: lib/Target/AMDGPU/SIMemoryLegalizer.cpp:415
       return Changed;
     } else {
       reportUnknownSynchScope(MI);
----------------
t-tye wrote:
> Suggest removing "else" from these "if"s as each one handles a specific case and returns. So no need for "else if" since plain "if" will be sufficient. At this point want to give the unhandled error since the preceding "if"s should have handled all the cases, so putting it outside the else makes that clearer.
> 
> Same comment for other expand functions.
Taken care of in D37397.


https://reviews.llvm.org/D36862