[PATCH] D37511: [dwarfdump] Verify line table prologue

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:455
+      } else {
+        llvm_unreachable("Invalid index?");
+      }
----------------
Don't branch-to-unreachable. Use an assert instead.

Is the false return from getFileNameByIndex really impossible? (has the FileIndex been checked for validity? What other error paths does getFileNameByIndex have, if any?)


Repository:
  rL LLVM

https://reviews.llvm.org/D37511