[PATCH] D35984: [mips][microMIPS] Add LAPC instruction

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 6 07:12:36 PDT 2017


sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM with inline nit addressed.



================
Comment at: test/MC/Mips/micromips32r6/invalid.s:41-44
+  lapc $7, 1048576         # CHECK: :[[@LINE]]:{{[0-9]+}}: error: expected both 19-bit signed immediate and multiple of 4
+  lapc $6, -1048580        # CHECK: :[[@LINE]]:{{[0-9]+}}: error: expected both 19-bit signed immediate and multiple of 4
+  lapc $3, 3               # CHECK: :[[@LINE]]:{{[0-9]+}}: error: expected both 19-bit signed immediate and multiple of 4
+  lapc $3, -1              # CHECK: :[[@LINE]]:{{[0-9]+}}: error: expected both 19-bit signed immediate and multiple of 4
----------------
This should be duplicated into test/MC/Mips/mips{32|64}r6/invalid.s .


https://reviews.llvm.org/D35984





More information about the llvm-commits mailing list