[PATCH] D37495: llvm-isel-fuzzer: Handle a subset of backend flags in the executable name

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: lib/FuzzMutate/FuzzerCLI.cpp:44
+  for (StringRef Opt : Opts) {
+    if (Opt.equals("gisel")) {
+      Args.push_back("-global-isel");
----------------
If there's a fuzzer writeup in llvm/docs, it might be worth mentioning these option names in it.


================
Comment at: lib/FuzzMutate/FuzzerCLI.cpp:61
+  for (std::string &S : Args)
+    CLArgs.push_back(S.c_str());
+
----------------
We might be able to get a tighter test by printing out the args here, then checking for them in filecheck.

Pro: default behaviors (e.g gisel => -O0) become clearer.
Con: This makes the fuzzer stdout a bit more crowded.


Repository:
  rL LLVM

https://reviews.llvm.org/D37495