[PATCH] D37391: [yaml2obj][ELF] Add support for symbol indexes greater than SHN_LORESERVE

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 5 12:22:13 PDT 2017


jakehehrlich updated this revision to Diff 113892.
jakehehrlich added a comment.

I agree that it should be *Symbol.Index. This was a mistake on my part.

1. Fixed not dereferencing the optional value
2. Changes indexes to be 16-bit instead of 32-bit

Ideally I'd like to have Sean or Simon look at this first before landing.


Repository:
  rL LLVM

https://reviews.llvm.org/D37391

Files:
  include/llvm/ObjectYAML/ELFYAML.h
  lib/ObjectYAML/ELFYAML.cpp
  test/tools/yaml2obj/symbol-index-invalid.yaml
  test/tools/yaml2obj/symbol-index.yaml
  tools/yaml2obj/yaml2elf.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37391.113892.patch
Type: text/x-patch
Size: 5922 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170905/eeaa0b43/attachment.bin>


More information about the llvm-commits mailing list