[PATCH] D32776: [PowerPC] Update branch coalescing to be a PowerPC specific pass

Kyle Butt via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 5 11:53:16 PDT 2017


iteratee requested changes to this revision.
iteratee added a comment.
This revision now requires changes to proceed.

I don't think this should go in, even off by default as long as it's broken. You can pull the produceSameValue check or fix it, but I don't like having a known-broken pass in tree.



================
Comment at: lib/CodeGen/TargetPassConfig.cpp:52
                          cl::desc("Enable interprocedural register allocation "
                                   "to reduce load/store at procedure calls."));
 static cl::opt<bool> DisablePostRASched("disable-post-ra", cl::Hidden,
----------------
lei wrote:
> iteratee wrote:
> > These seem unrelated. Can you pull them out?
> I do not understand why you want me to pull these out.  They were not added by me and it is being used later on in this src.
Sorry, I was trying to look at your original diff vs this one to see what changed. 


https://reviews.llvm.org/D32776





More information about the llvm-commits mailing list