[PATCH] D37321: llvm-mt: Fix memory management in WindowsManifestMergerImpl::getMergedManifest

Eric Beckmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 5 11:47:13 PDT 2017


ecbeckmann added a comment.

In https://reviews.llvm.org/D37321#859384, @vitalybuka wrote:

> > This seems better than using XML_PARSE_NODICT, because we also address the issue of any other memory I might have failed to copy....I could do this in a subsequent patch.
>
> So I'll submit the patch?
>  I'll try to enable this on our asan bot to detect problems in future.


Sorry for late response.  Sounds good.


Repository:
  rL LLVM

https://reviews.llvm.org/D37321





More information about the llvm-commits mailing list