[PATCH] D37484: [libunwind] Always use unwind tables in tests

[Jonathan Roelofs via Phabricator via llvm-commits]

jroelofs added inline comments.


================
Comment at: test/libunwind/test/config.py:46
         self.cxx.compile_flags += ['-DLIBUNWIND_NO_TIMER']
-        if self.get_lit_bool('enable_exceptions', True):
-            self.cxx.compile_flags += ['-funwind-tables']
-        else:
+        if self.get_lit_bool('enable_exceptions', False):
             self.cxx.compile_flags += ['-fno-exceptions', '-DLIBUNWIND_HAS_NO_EXCEPTIONS']
----------------
I don't think that's correct. It should be:


```
if not self.get_lit_bool('enable_exceptions', True):
    self.cxx.compile_flags += ['-fno-exceptions', '-DLIBUNWIND_HAS_NO_EXCEPTIONS']
```

i.e: treat 'enable_exceptions' as True if it's not found, and only add the compile flags turning exceptions off when it's known to be False.


https://reviews.llvm.org/D37484