[PATCH] D37452: lld-link: Add --rsp-quoting= flag

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 4 16:36:37 PDT 2017


thakis created this revision.

This ports https://reviews.llvm.org/D19425 from clang / https://reviews.llvm.org/D22015 from the ELF port to COFF lld. This can be useful when linking COFF files on a posix host.

It's not clear to me if --rsp-quoting should affect how we parse %LINK% and %_LINK_%. Since the flag is about shell parsing of sorts, I decided it should, but I'm happy to be talked out of it. (I think it should definitely not affect .drective parsing.) Making --rsp-quoting affect LINK parsing does make the patch a bit more complicated, because we end up parsing args 3 times now: Once to inspect --rsp-quoting for LINK handling, and then once more to inspect --rsp-quoting for regular response file expansion.


https://reviews.llvm.org/D37452

Files:
  COFF/Driver.cpp
  COFF/Driver.h
  COFF/DriverUtils.cpp
  COFF/Options.td
  test/COFF/linkenv.test
  test/COFF/responsefile.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37452.113794.patch
Type: text/x-patch
Size: 8791 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170904/c2d55975/attachment.bin>


More information about the llvm-commits mailing list