[PATCH] D37274: [InstCombine] Remove foldSelectICmpAndOr. Instead call foldSelectICmpAnd as part of foldSelectIntoOp

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

I vote to split this up:

1. Can you make the APInt changes for getSelectFoldableConstant() and isSelect01() as an NFC preliminary commit?
2. Could also do the move of foldSelectICmpAnd() as a prelim to shrink this down to just the core diff.
3. Add all of the new tests ahead of this.
4. Fix the hasOneUse() deficiency first to avoid regressions.

Re: the pattern with a shift - add a blurb to the comments about *why* it's disabled?


https://reviews.llvm.org/D37274