[PATCH] D36823: [LLD][ELF] Read ARM BuildAttributes section to determine supported features.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/InputFiles.cpp:372
+    case ARMBuildAttrs::v6KZ:
+    case ARMBuildAttrs::v6K:
+      Config->ARMHasBlx = true;
----------------
peter.smith wrote:
> grimar wrote:
> > Is `v6T2` intentionally missing from this list ?
> Yes it is. The ARMBuildAttrs v6T2 should be covered by the default: case. I've attempted to explain this with the comment:
> 
> ```
>       // Architectures used in pre-Cortex processors do not support
>       // The J1 = 1 J2 = 1 Thumb branch range extension, with the exception
>       // of Architecture v6T2 (arm1156t2-s and arm1156t2f-s) that do.
> ```
> If that isn't clear? I can reword it.
>  
> 
> 
Ah I see now, sorry for noise here. Comment looks fine.


https://reviews.llvm.org/D36823