[PATCH] D36831: [AMDGPU] Transform __read_pipe_* and __write_pipe_*

[Valery Pykhtin via Phabricator via llvm-commits]

vpykhtin added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPULibFunc.h:366
 
-  void          reset();
+  static StringRef getUnmangledName(const StringRef &mangledName);
 
----------------
rampitec wrote:
> yaxunl wrote:
> > rampitec wrote:
> > > StringRef designed to be passed by value, here and below.
> > This comes from the original implementation. Will fix.
> Not done.
Initially (non-const) StringRef& was introduced intentionally to have mangledName with stripped name on return.


https://reviews.llvm.org/D36831