[PATCH] D37410: LTO: Try to open cache files before renaming them.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

LGTM



================
Comment at: llvm/include/llvm/LTO/Caching.h:27
 ///
-/// MB->getBufferIdentifier() is a valid path for the file at the time that it
-/// was opened, but clients should prefer to access MB directly in order to
-/// avoid a potential race condition.
+/// Path is a valid path for the file at the time that it was opened, but
+/// clients should prefer to access MB directly in order to avoid a potential
----------------
The comment is not accurate I believe: the `Path` didn't exist when when the memory buffer was created, and it was never opened using this path.


https://reviews.llvm.org/D37410