[PATCH] D37365: [x86] Enable f128 as a legal type in 64-bit mode if SSE is enabled rather than if MMX is enabled.

[Chih-Hung Hsieh via Phabricator via llvm-commits]

chh requested changes to this revision.
chh added a comment.
This revision now requires changes to proceed.

I cannot get clang to crash with "clang -c -mno-mmx" and the given example.
Maybe I missed something?

It also looks opposite to the problem of "... with sse disabled and mmx 
enabled, you get an error about not being able to use an SSE register 
for a return ..."
Could you include an example to reproduce that error?

Although replacing hasMMX with hasSSE1 looked logical and it passed 
most Android used modes, the failed unit test cases showed
incompatible ABI generated for some other modes like SSE and AVX.
We need to find out if those before change output were correct or not.
Even if they were incorrect, I am not sure about breaking the compatibility.

Some of the unit test checks in extract-store.ll were removed.
They should be kept and changed to check new output pattern if necessary.


https://reviews.llvm.org/D37365