[PATCH] D37371: [llvm-dwp] Add command line option "-e"

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Some things to tidy up in the test, some optional.



================
Comment at: test/tools/llvm-dwp/X86/dwos_list_from_exec_simple.test:16-18
+  int a() {
+    return 1;
+  }
----------------
You could simplify these a bit by just making them void:

  void a() {}

etc.


================
Comment at: test/tools/llvm-dwp/X86/dwos_list_from_exec_simple.test:21-26
+  int b() {
+    return 2;
+  }
+  int main() {
+     return 0;
+  }
----------------
Could have main here and drop 'b', I'd expect.


================
Comment at: test/tools/llvm-dwp/X86/dwos_list_from_exec_simple.test:43-68
+CHECK-LABEL: .debug_abbrev.dwo contents:
+
+CHECK-LABEL: Abbrev table for offset:
+CHECK: DW_TAG_compile_unit
+CHECK: DW_TAG_subprogram
+CHECK: DW_TAG_base_type
+
----------------
Is it worth checking the abbrevs? Seems like it might be enough to just check the DW_AT_names?


================
Comment at: test/tools/llvm-dwp/X86/dwos_list_from_exec_simple.test:76
+CHECK:   DW_AT_name {{.*}} "c.cpp"
+CHECK:   DW_AT_GNU_dwo_id {{.*}} ([[DWOA:.*]])
+CHECK:   DW_TAG_subprogram
----------------
This seems wrong - you're not using the DWOA value, and you're rematching it on every dwo_id? Probably skip that.


Repository:
  rL LLVM

https://reviews.llvm.org/D37371